desk-moloni/.specify/tasks.md

📋 TASKS BREAKDOWN - desk-moloni Quality Fixes

🚨 CURRENT SPRINT: QUALITY ASSURANCE & PRODUCTION READINESS

PHASE 1: CRITICAL SYNTAX FIXES (P1) 🔥

• T001: Fix syntax error in ClientSyncService.php:450

  • File: modules/desk_moloni/libraries/ClientSyncService.php
  • Issue: Missing semicolon after $contact['alternative_email'] ?? ''
  • Estimate: 5 min
  • Priority: CRITICAL
  • Agent: php-fullstack-engineer
  • Acceptance: PHP syntax error resolved, file validates with php -l

• T002: Fix switch case syntax in SyncWorkflowFeatureTest.php:262

  • File: tests/feature/SyncWorkflowFeatureTest.php
  • Issue: Incorrect syntax in switch statement case 'seasonal_bulk_sync',
  • Estimate: 10 min
  • Priority: CRITICAL
  • Agent: dev-helper
  • Dependencies: None
  • Acceptance: Test file syntax validates, no PHPStan errors

• T003: Run comprehensive PHPStan analysis for remaining syntax errors

  • Command: ./vendor/bin/phpstan analyse . --level=5
  • Estimate: 15 min
  • Priority: HIGH
  • Agent: development-lead
  • Dependencies: T001, T002
  • Acceptance: All critical syntax errors identified and documented

PHASE 2: ENVIRONMENT SETUP (P2) ⚙️

• T004: Install missing PHP extensions [P]

  • Extensions: php8.3-dom, php8.3-mbstring, php8.3-xml, php8.3-xmlwriter
  • Commands: System-level package installation
  • Estimate: 15 min
  • Priority: HIGH
  • Agent: system-development-agent
  • Dependencies: None
  • Acceptance: PHPUnit executes without extension errors

• T005: Fix namespace issues in library files [P]

  • Files:
    • modules/desk_moloni/libraries/Encryption.php (line 18)
    • modules/desk_moloni/libraries/EntityMappingService.php (line 21)
  • Issue: Namespace declaration not first statement
  • Estimate: 20 min
  • Priority: HIGH
  • Agent: php-fullstack-engineer
  • Dependencies: None
  • Acceptance: Files comply with PSR-4, autoloading works correctly

• T006: Fix namespace issues in test files [P]

  • Files:
    • modules/desk_moloni/tests/contract/ConfigTableTest.php (line 16)
    • modules/desk_moloni/tests/contract/MoloniApiContractTest.php (line 10)
  • Issue: Namespace declaration positioning
  • Estimate: 15 min
  • Priority: MEDIUM
  • Agent: dev-helper
  • Dependencies: None
  • Acceptance: Test files validate, proper namespace structure

PHASE 3: STRUCTURE & COMPLIANCE (P3) 📁

• T007: Create missing assets directory structure [P]

  • Action: Create /assets/ directory with standard subdirectories
  • Structure: assets/{css,js,images,fonts}/
  • Estimate: 5 min
  • Priority: MEDIUM
  • Agent: system-development-agent
  • Dependencies: None
  • Acceptance: Production readiness validator passes directory check

• T008: Fix PSR-4 autoloading compliance [P]

  • Files: All test classes not following PSR-4 standard
  • Action: Adjust class paths or update autoloading configuration
  • Estimate: 15 min
  • Priority: MEDIUM
  • Agent: php-fullstack-engineer
  • Dependencies: None
  • Acceptance: Composer autoload warnings eliminated, performance improved

• T009: Update composer.json PHP version requirement [P]

  • File: composer.json
  • Change: Update "php": "^8.4" to "php": "^8.3" (already done)
  • Estimate: 2 min
  • Priority: LOW
  • Agent: dev-helper
  • Dependencies: None
  • Acceptance: Composer validates without PHP version conflicts

PHASE 4: VALIDATION & TESTING (P4) ✅

• T010: Execute comprehensive PHPStan validation

  • Command: ./vendor/bin/phpstan analyse . --level=5
  • Target: Zero syntax errors, maximum quality score
  • Estimate: 10 min
  • Priority: HIGH
  • Agent: development-lead
  • Dependencies: T001-T009
  • Acceptance: PHPStan reports 0 critical errors

• T011: Validate PHPUnit environment

  • Command: ./vendor/bin/phpunit --version
  • Target: PHPUnit executes without extension errors
  • Estimate: 5 min
  • Priority: HIGH
  • Agent: dev-helper
  • Dependencies: T004
  • Acceptance: PHPUnit ready for test execution

• T012: Run production readiness validation

  • Script: ./scripts/production_readiness_validator.sh
  • Target: All critical checks PASS
  • Estimate: 10 min
  • Priority: HIGH
  • Agent: security-compliance-specialist
  • Dependencies: T001-T011
  • Acceptance: Production validator reports READY status

• T013: Generate final quality report

  • Action: Document all fixes applied and final status
  • Output: QUALITY_FIXES_REPORT.md
  • Estimate: 15 min
  • Priority: MEDIUM
  • Agent: content-manager
  • Dependencies: T001-T012
  • Acceptance: Complete documentation of quality improvements

🎯 PARALLEL EXECUTION GROUPS

Group A [P]: T004, T005, T006 (Environment & Namespace fixes) Group B [P]: T007, T008, T009 (Structure & Compliance)

🔄 EXECUTION SEQUENCE

T001 → T002 → T003 → [T004, T005, T006] → [T007, T008, T009] → T010 → T011 → T012 → T013

📊 SPRINT SUMMARY

Sprint Metrics

• Total Tasks: 13
• Total Estimated Time: ~127 minutes (2.1 hours)
• Average Task Size: 9.8 minutes
• Sprint Duration: 1 day (same-day completion)
• Team Size: Automated agent orchestration

Task Distribution

Priority CRITICAL:  2 tasks (15.4%) - Syntax fixes
Priority HIGH:      6 tasks (46.2%) - Environment & validation
Priority MEDIUM:    4 tasks (30.8%) - Structure & compliance
Priority LOW:       1 task  (7.7%)  - Version update

Phase Distribution

Phase 1 (Critical):   3 tasks - 30 min (23.6%)
Phase 2 (Environment): 3 tasks - 50 min (39.4%)
Phase 3 (Structure):   3 tasks - 22 min (17.3%)
Phase 4 (Validation):  4 tasks - 40 min (31.5%)

Agent Specialization

php-fullstack-engineer:     T001, T005, T008 (PHP expertise)
dev-helper:                 T002, T006, T009, T011 (General development)
development-lead:           T003, T010 (Architecture & validation)
system-development-agent:   T004, T007 (Infrastructure)
security-compliance-specialist: T012 (Production compliance)
content-manager:            T013 (Documentation)

Dependencies Map

T001 → T002 → T003
T003 → [T004, T005, T006] (Parallel Group A)
T003 → [T007, T008, T009] (Parallel Group B)
[T004-T009] → T010 → T011 → T012 → T013

🎯 EXECUTION STRATEGY

Parallel Optimization

• Phase 2: 3 tasks in parallel (saves 35 minutes)
• Phase 3: 3 tasks in parallel (saves 20 minutes)
• Total parallelization savings: 55 minutes

Quality Gates

1. Syntax validation after each PHP fix
2. PHPStan analysis after all syntax fixes
3. Extension check after environment setup
4. Final validation with all tools integrated

Success Criteria

• ✅ Zero PHPStan syntax errors
• ✅ PHPUnit executes without extension errors
• ✅ Production readiness validator: PASS
• ✅ All files comply with PSR-4
• ✅ Required directory structure exists

---

Version: 2.0 | Last Update: 2025-09-13 01:33 | Sprint: Quality Assurance & Production Readiness